Skip to content

Commit

Permalink
update comments, add changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
huangzhen1997 committed Aug 5, 2024
1 parent 1cf6da7 commit cc0c592
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/cuddly-eels-lay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

Improve TXM performance by optimize Confirmer and Finalizer queries to stop pulling EVM receipt. #internal #changed #updated
4 changes: 2 additions & 2 deletions core/chains/evm/txmgr/evm_tx_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ func (o *evmTxStore) loadEthTxesAttemptsReceipts(ctx context.Context, etxs []*Tx
return nil
}

// loadEthTxesAttemptsPartialReceipts loads ethTxes with attempts contains partial values for optimization
// loadEthTxesAttemptsPartialReceipts loads ethTxes with partial attempts values for optimization
func (o *evmTxStore) loadEthTxesAttemptsPartialReceipts(ctx context.Context, etxs []*Tx) (err error) {
attemptHashM, attemptHashes, empty := initEthTxesAttempts(etxs)
if empty {
Expand Down Expand Up @@ -1210,7 +1210,7 @@ ORDER BY nonce ASC
return pkgerrors.Wrap(err, "FindTransactionsConfirmedInBlockRange failed to load evm.tx_attempts")
}

// retrieve tx with attempts which contain partial values for optimization purpose
// retrieve tx with attempts which contain partial attempts values for optimization purpose
err = orm.loadEthTxesAttemptsPartialReceipts(ctx, etxs)
return pkgerrors.Wrap(err, "FindTransactionsConfirmedInBlockRange failed to load evm.receipts")
})
Expand Down

0 comments on commit cc0c592

Please sign in to comment.