add startonce protection to syncer (#13917)

smartcontractkit · Jul 24, 2024 · c5224df · c5224df
1 parent 780d304
commit c5224df
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/.changeset/friendly-needles-ring.md b/.changeset/friendly-needles-ring.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal syncer start onc3
diff --git a/core/services/registrysyncer/syncer.go b/core/services/registrysyncer/syncer.go
@@ -36,6 +36,7 @@ type Syncer interface {
 }
 
 type registrySyncer struct {
+	services.StateMachine
 	stopCh          services.StopChan
 	launchers       []Launcher
 	reader          types.ContractReader
@@ -118,12 +119,14 @@ func newReader(ctx context.Context, lggr logger.Logger, relayer contractReaderFa
 }
 
 func (s *registrySyncer) Start(ctx context.Context) error {
-	s.wg.Add(1)
-	go func() {
-		defer s.wg.Done()
-		s.syncLoop()
-	}()
-	return nil
+	return s.StartOnce("testAsyncMessageBroker", func() error {
+		s.wg.Add(1)
+		go func() {
+			defer s.wg.Done()
+			s.syncLoop()
+		}()
+		return nil
+	})
 }
 
 func (s *registrySyncer) syncLoop() {
@@ -232,9 +235,11 @@ func (s *registrySyncer) AddLauncher(launchers ...Launcher) {
 }
 
 func (s *registrySyncer) Close() error {
-	close(s.stopCh)
-	s.wg.Wait()
-	return nil
+	return s.StopOnce("testAsyncMessageBroker", func() error {
+		close(s.stopCh)
+		s.wg.Wait()
+		return nil
+	})
 }
 
 func (s *registrySyncer) Ready() error {