Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
poopoothegorilla committed Jan 5, 2024
1 parent 1fe825c commit 9ed1651
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions common/txmgr/address_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,6 @@ func NewAddressState[
}

func (as *AddressState[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) close() {
as.Lock()
defer as.Unlock()

as.unstarted.Close()
as.unstarted = nil
as.inprogress = nil
Expand Down
2 changes: 1 addition & 1 deletion common/txmgr/inmemory_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import (
)

// BIG TODO LIST
// TODO: make sure that all state transitions are handled by the address state to ensure that the in-memory store is always in a consistent state
// TODO: figure out if multiple tx attempts are actually stored in the db for each tx
// TODO: need a way to get id for a tx attempt. since there are some methods where the persistent store creates a tx attempt and doesnt returns it
// TODO: should txAttempt state transitions be handled by the address state manager?

var (
// ErrInvalidChainID is returned when the chain ID is invalid
Expand Down

0 comments on commit 9ed1651

Please sign in to comment.