Fix lint

core/services/llo/data_source_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"math"
 	"math/big"
 	"sync"
 	"testing"
@@ -229,6 +230,10 @@ func BenchmarkObserve(b *testing.B) {
 	db := pgtest.NewSqlxDB(b)
 	bridgesORM := bridges.NewORM(db)
 
+	if b.N > math.MaxInt32 {
+		b.Fatalf("N is too large: %d", b.N)
+	}
+
 	n := uint32(b.N)
 
 	createBridge(b, "foo-bridge", `123.456`, bridgesORM, 0)
@@ -249,9 +254,7 @@ func BenchmarkObserve(b *testing.B) {
 	)
 
 	r := streams.NewRegistry(lggr, runner)
-	for i := uint32(0); i < n; i++ {
-		jobStreamID := streams.StreamID(i)
-
+	for jobStreamID := uint32(0); i < n; i++ {
 		jb := job.Job{
 			ID:       int32(i),
 			Name:     null.StringFrom(fmt.Sprintf("job-%d", i)),

core/services/llo/observation_context_test.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"math"
 	"math/rand/v2"
 	"net/http"
 	"net/http/httptest"
@@ -280,6 +281,9 @@ func BenchmarkObservationContext_Observe_integrationRealPipeline_concurrencyStre
 	db := pgtest.NewSqlxDB(t)
 	bridgesORM := bridges.NewORM(db)
 
+	if b.N > math.MaxInt32 {
+		b.Fatalf("N is too large: %d", b.N)
+	}
 	n := uint32(t.N)
 
 	createBridge(t, "foo-bridge", `123.456`, bridgesORM, 0)
@@ -301,9 +305,7 @@ func BenchmarkObservationContext_Observe_integrationRealPipeline_concurrencyStre
 
 	r := streams.NewRegistry(lggr, runner)
 
-	for i := uint32(0); i < n; i++ {
-		jobStreamID := streams.StreamID(i)
-
+	for jobStreamID := uint32(0); i < n; i++ {
 		jb := job.Job{
 			ID:       int32(i),
 			Name:     null.StringFrom(fmt.Sprintf("job-%d", i)),
@@ -344,7 +346,7 @@ result3 -> result3_parse -> multiply3;
 		for _, strmID := range []uint32{i, i + n, i + 2*n, i + 3*n} {
 			g.Go(func() error {
 				// ignore errors, only care about races
-				oc.Observe(ctx, strmID, opts)
+				_ := oc.Observe(ctx, strmID, opts)
 				return nil
 			})
 		}