Merge branch 'develop' into feature/KS-354-streams-agg-test

smartcontractkit · Jun 27, 2024 · 6383998 · 6383998
2 parents 6cad6cc + 7a3ba8e
commit 6383998
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/contracts/src/v0.8/keystone/CapabilitiesRegistry.sol b/contracts/src/v0.8/keystone/CapabilitiesRegistry.sol
@@ -1010,10 +1010,7 @@ contract CapabilitiesRegistry is OwnerIsCreator, TypeAndVersionInterface {
       /// beforeCapabilityConfigSet
       if (
         capability.configurationContract.code.length == 0 ||
-        !IERC165(capability.configurationContract).supportsInterface(
-          ICapabilityConfiguration.getCapabilityConfiguration.selector ^
-            ICapabilityConfiguration.beforeCapabilityConfigSet.selector
-        )
+        !IERC165(capability.configurationContract).supportsInterface(type(ICapabilityConfiguration).interfaceId)
       ) revert InvalidCapabilityConfigurationContractInterface(capability.configurationContract);
     }
     s_capabilities[hashedCapabilityId] = capability;

diff --git a/core/services/workflows/engine.go b/core/services/workflows/engine.go
@@ -355,9 +355,25 @@ func (e *Engine) registerTrigger(ctx context.Context, t *triggerCapability, trig
 			}}
 	}
 
+	e.wg.Add(1)
 	go func() {
-		for event := range eventsCh {
-			e.triggerEvents <- event
+		defer e.wg.Done()
+
+		for {
+			select {
+			case <-e.stopCh:
+				return
+			case event, isOpen := <-eventsCh:
+				if !isOpen {
+					return
+				}
+
+				select {
+				case <-e.stopCh:
+					return
+				case e.triggerEvents <- event:
+				}
+			}
 		}
 	}()