Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit #557

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Audit #557

wants to merge 15 commits into from

Conversation

augustbleeds
Copy link
Collaborator

@augustbleeds augustbleeds commented Nov 26, 2024 •
edited
Loading

Taken from #533 (but PR was closed prematurely)

Note: this will NOT be merged to develop until the audit is completed in order to avoid the situation where Ops deploys updated contracts.

Bumping scarb/cairo to version 2.8.2. Because this changes the compile contracts (and the dependencies), this will stay as a PR and will not be merged. After the audit is completed, then it'll be merged to develop

  • bump cairo/starknet version
  • open zeppelin bump -- make sure OZ is updated, but also bc there is a breaking erc-20 change for event indexing
  • update build process (no longer use cairo directly, but via scarb)
  • update foundry
  • add recently added contracts (MCM + Timelock)
  • update proxy contract

@augustbleeds augustbleeds requested review from a team as code owners November 26, 2024 14:45
chainchad
chainchad reviewed Nov 26, 2024
View reviewed changes
.github/actions/install-cairo/action.yml
Comment on lines +41 to +42
wget https://github.com/software-mansion/scarb/releases/download/${{ inputs.scarb_version }}/scarb-${{ inputs.scarb_version }}-x86_64-unknown-linux-${libc_version}.tar.gz
tar -xvzf scarb-${{ inputs.scarb_version }}-x86_64-unknown-linux-${libc_version}.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this example where we check the shasum of the file.

@augustbleeds
disable proxy check (#560)
3f63ca6 
* disable proxy access check by default

* remove
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustbleeds @chainchad