starknet monitoring: paginate events #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
|
augustbleeds
commented
Aug 6, 2024
| chunk, err := c.r.Events(ctx, input) | ||
| events = chunk.Events | ||
|
|
||
| // TODO: check events.isLastPage, query more if needed |
There was a problem hiding this comment.
this todo was never implemented, so this PR is doing it (basically)
augustbleeds
commented
Aug 6, 2024
| t.Run("get new transmission event", func(t *testing.T) { | ||
| events, err := client.NewTransmissionsFromEventsAt(context.Background(), contractAddress, 123) | ||
| require.NoError(t, err) | ||
| assert.Len(t, events, 15) |
There was a problem hiding this comment.
just assert that we did in fact paginate to get 15 results. if we didn't then we'd only get 10 results
augustbleeds
commented
Aug 6, 2024
|
|
||
| configSetSelector := starknetutils.GetSelectorFromNameFelt("ConfigSet") | ||
|
|
||
| if eventsReq.EventFilter.Keys[0][0].Equal(configSetSelector) { |
There was a problem hiding this comment.
way to distinguish what mocked result to return to the client
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCI-3958
monitor was broken because the pagination was never implemented, so for blocks with more than 10 events of the same type, it may be impossible to find the transmission event