stop giving false signal to transmit #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
|
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
approved these changes
Aug 2, 2024
chris-de-leon-cll
approved these changes
Aug 2, 2024
augustbleeds
added a commit
that referenced
this pull request
Aug 2, 2024
augustbleeds
added a commit
that referenced
this pull request
Aug 2, 2024
chray-zhang
pushed a commit
that referenced
this pull request
Nov 25, 2024
chray-zhang
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug where we are transmitting too frequently. This discovery came as an investigation into why we were over-transmitting even when the deviation threshold was not met. It happens because the LatestRoundRequested shouldn't be triggered on Starknet.
refer to: https://github.com/smartcontractkit/libocr/blob/master/offchainreporting/internal/protocol/report_generation_follower.go#L499 (libocr)
https://github.com/smartcontractkit/chainlink-solana/blob/02a42e04dc42d30a41f07dd100cf1062e0c04a16/pkg/solana/median_contract.go#L64 (how solana deals with it)