Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar bump #360

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Sonar bump #360

merged 2 commits into from
Feb 27, 2024

Conversation

smickovskid
Copy link
Contributor

  • Sonar bump

archseer
archseer reviewed Feb 21, 2024
View reviewed changes
.github/workflows/sonar-scan.yml Outdated
@@ -101,7 +101,7 @@ jobs:
run: sed -i 's+/home/runner/work/feeds-manager/feeds-manager/+/github/workspace/+g' ${{ steps.sonarqube_report_paths.outputs.sonarqube_eslint_report_paths }}

- name: SonarQube Scan
uses: sonarsource/sonarqube-scan-action@a6ba0aafc293e03de5437af7edbc97f7d3ebc91a # v1.2.0
uses: sonarsource/[email protected].1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for security reasons we're always supposed to pin to a sha rather than a tag

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@archseer archseer merged commit 4ebc7bb into develop Feb 27, 2024
15 of 20 checks passed
@archseer archseer deleted the sonar_bump branch February 27, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smickovskid @archseer