[BCI 2027]: Adds multisig cairo tests #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new test cases for the following functions:
set_threshold
set_signers
set_signers_and_threshold
For each function above, there are 2 new corresponding test cases: a recursive version and a non-recursive version.
In the recursive version, a transaction is created which calls one of the Multisig functions above. This transaction is submitted to the Multisig contract, which is then confirmed by the correct number of signers and executed. The test case verifies the state before and after the transaction execution.
In the non-recursive version, the Multisig contract is deployed, and the methods on it are directly called using a dispatcher. There is no transaction submission/confirmation. The test simply calls a function and verifies that the result is correct.
I believe the recursive version is what the ticket here is referring to, but I included both versions for completeness.