SonarQube integration #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
previously approved these changes
Jun 23, 2023
krebernisak
reviewed
Jul 4, 2023
| @@ -162,15 +162,15 @@ format-ts-check: | |||
|
|
|||
| .PHONY: lint-go-ops | |||
| lint-go-ops: | |||
There was a problem hiding this comment.
Please use this opportunity to make these Makefile actions and CI workflows consistent across our projects (Solana, Cosmos, Starknet).
smickovskid
force-pushed
the
chore/QA-1205-Add-chainlink-starknet-to-Sonar
branch
from
ce6aefb to
8d99752
Compare
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
had a problem deploying
to
integration
GitHub Actions
Failure
smickovskid
had a problem deploying
to
integration
GitHub Actions
Error
chudilka1
approved these changes
Sep 5, 2023
cfal
previously approved these changes
Sep 6, 2023
chudilka1
requested changes
Sep 6, 2023
| uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0 | ||
| with: | ||
| name: golangci-lint-integration-tests-report | ||
| path: ./integration-tests/golangci-lint-integration-tests-report.xml | ||
| # Note: I could not figure out why the golangci-lint-action would not work even though it is technically running the same as above, error message is this: | ||
| # Running [/home/runner/golangci-lint-1.50.1-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=integration-tests --exclude=dot-imports] in [/home/runner/work/chainlink-starknet/chainlink-starknet/integration-tests] ... | ||
| # level=warning msg="[runner] Can't run linter goanalysis_metalinter: inspect: failed to load package client: could not load export data: no export data for \"github.com/smartcontractkit/chainlink-testing-framework/client\"" |
There was a problem hiding this comment.
The report is generated, take a look here
I believe the version of the linter, should be bumped to v1.51.1 # this version has an --out-format checkstyle necessary for Sonar
Ref: smartcontractkit/golangci-lint-action@54ab6c5
To test, you can try adding the unused variable to a go file analyzed by linter, eventually you should get a code smell in Sonar with label GOLANGCI-LINT.
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
smickovskid
had a problem deploying
to
integration
GitHub Actions
Error
smickovskid
had a problem deploying
to
integration
GitHub Actions
Failure
smickovskid
approved these changes
Sep 11, 2023
smickovskid
deleted the
chore/QA-1205-Add-chainlink-starknet-to-Sonar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.