Skip to content

Commit

Permalink
remove comments
Browse files Browse the repository at this point in the history
  • Loading branch information
augustbleeds committed Sep 17, 2024
1 parent c5df72f commit 002ba37
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions contracts/src/mcms.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ struct RootMetadata {
override_previous_root: bool
}

// todo: maybe use copy
// todo: figure out how this works off-chain with MCMS since we have a new selector field here
#[derive(Copy, Drop, Serde)]
struct Op {
chain_id: u256,
Expand Down Expand Up @@ -144,7 +142,6 @@ const MANY_CHAIN_MULTI_SIG_DOMAIN_SEPARATOR_OP: u256 =
const MANY_CHAIN_MULTI_SIG_DOMAIN_SEPARATOR_METADATA: u256 =
0xe6b82be989101b4eb519770114b997b97b3c8707515286748a871717f0e4ea1c;

// todo: make sure this is the right way to encode the struct
fn hash_metadata(metadata: RootMetadata, valid_until: u32) -> u256 {
let encoded_metadata: Bytes = BytesTrait::new_empty()
.encode(MANY_CHAIN_MULTI_SIG_DOMAIN_SEPARATOR_METADATA)
Expand Down
6 changes: 0 additions & 6 deletions contracts/src/tests/test_mcms/test_set_root.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -735,12 +735,6 @@ fn test_wrong_pre_op_count() {
}
}
}
// todo: make signer metadata a constant so you don't need to repeat yourself

// todo: do two executes in between and then set the wrong root

// pre - 2
// post - 1

#[test]
#[feature("safe_dispatcher")]
Expand Down

0 comments on commit 002ba37

Please sign in to comment.