LogPoller Boilerplate #950
Conversation
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
|
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
| ) | ||
|
|
||
| type EventSaver interface { | ||
| SaveEvent(evt ProgramEvent) error |
There was a problem hiding this comment.
This will need to accept a slice of events, more like this:
| SaveEvent(evt ProgramEvent) error | |
| SaveEvents(events []ProgramEvent) error |
But we already have an ORM method that does basically that, so we can probably just use that unless we want to wrap it with some conversion layer:
InsertLogs(logs []Log) error
There was a problem hiding this comment.
That works. This method is only a placeholder and can use the ORM method instead.
| return p | ||
| } | ||
|
|
||
| func (p *Service) AddFilter(name string) error { |
There was a problem hiding this comment.
This looks like RegisterFilter() we have that implemented and is in review.
There was a problem hiding this comment.
The interface for LogPoller (as well as all of the data structures that will be passed between QueryKey & LogPoller) is fully specified in the design doc. In principle, that should be enough for QueryKey to be implemented, and should be considered the source of truth--so I'd recommend starting there, and if there is anything missing or that needs to be updated in light of more recent conversations we can discuss.
basic boilerplate that connects loader to base log poller