Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MultiNode #930

Closed
wants to merge 1 commit into from
Closed

Disable MultiNode #930

wants to merge 1 commit into from

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Nov 18, 2024 •
edited
Loading

Description

Disable MultiNode in Smoke Tests by default since heads are not fully produced in testing causing integration tests to be flaky.

@DylanTinianov DylanTinianov self-assigned this Nov 18, 2024
@DylanTinianov DylanTinianov requested review from a team as code owners November 18, 2024 16:27
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

aalu1418
aalu1418 reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we disabling a feature?

the core side tests run the same exact tests as the solana side

if there is flakiness, let's find/fix the root cause please

@dhaidashenko dhaidashenko self-requested a review November 18, 2024 17:35
@DylanTinianov DylanTinianov deleted the disable-multinode-smoke-tests branch November 18, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 left review comments

@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @dhaidashenko @aalu1418