Batch Contract Read #926
Merged
Batch Contract Read #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
| } | ||
|
|
||
| *ptrToValue = value | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Don't we still need to set returnVal.(*values.Value)?
There was a problem hiding this comment.
The type casting creates the pointer to the value. Setting the value on line 157 is correct. You can see the implementation in evm is the same.
ilija42
reviewed
Nov 15, 2024
| binding.Decode(ctx, data[idx], contractType), | ||
| ) | ||
|
|
||
| value, err := values.Wrap(contractType) |
There was a problem hiding this comment.
In what format does the rpc return data? Do we have to da a borsh decode?
There was a problem hiding this comment.
Since the start, we have been assuming binary encoded data (borsh). The other option is JSON but so far expectations did not include json.
ilija42
reviewed
Nov 15, 2024
Batch contract reads are added and multiple address support was removed. All tests now pass.
EasterTheBunny
force-pushed
the
ah/batch-contract-read
branch
from
27a3c1b
to
3c98680
Compare
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
GitHub Actions
Error
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
|
ilija42
approved these changes
Nov 18, 2024
aalu1418
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch contract reads are added and multiple address support was removed. All tests now pass.