Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCFR-966 - Update Solana to support disable chain component tests #878

Merged
merged 4 commits into from
Nov 12, 2024
Merged

BCFR-966 - Update Solana to support disable chain component tests #878

merged 4 commits into from
Nov 12, 2024

Conversation

pablolagreca
Copy link
Collaborator

Description

Add missing methods to support disabling chain component tests

@pablolagreca pablolagreca requested review from a team as code owners October 3, 2024 14:47
Farber98
Farber98 previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should make a follow up PR to use this logic for skipping tests instead of doing it manually through Skip()

@ilija42 ilija42 mentioned this pull request Oct 7, 2024
Merged
ilija42
ilija42 reviewed Oct 7, 2024
View reviewed changes
go.mod Outdated
@@ -129,3 +129,5 @@ require (
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)

//replace github.com/smartcontractkit/chainlink-common => ../chainlink-common
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be deleted

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@cfal cfal merged commit efd6780 into develop Nov 12, 2024
34 checks passed
@cfal cfal deleted the BCFR-966 branch November 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfal cfal cfal approved these changes

@aalu1418 aalu1418 aalu1418 left review comments

@Farber98 Farber98 Awaiting requested review from Farber98

@ilija42 ilija42 Awaiting requested review from ilija42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablolagreca @cfal @Farber98 @aalu1418 @ilija42