Keystone: forwarder + write target #614
Conversation
archseer
force-pushed
the
keystone-forwarder
branch
from
f1148ba to
b99ddf1
Compare
| } | ||
|
|
||
| // TODO: encode inputs into data | ||
| data = append(data, inputs["report"].([]byte)...) |
There was a problem hiding this comment.
looks like we are missing the evaluateParams step from the EVM side. Any reason this isn't included the same way it was done on EVM? Seems weird to pull the data from "report" vs the more complex eval we are doing on EVM. If that's what the TODO is for, no worries :)
|
|
||
| tx, err := sdk.NewTransaction( | ||
| []sdk.Instruction{ | ||
| sdk.NewInstruction(config.ForwarderProgramID, accounts, data), |
There was a problem hiding this comment.
why does solana use multiple accounts here?
| } | ||
|
|
||
| go func() { | ||
| // TODO: cast tx.Error to Err (or Value to Value?) |
There was a problem hiding this comment.
In this case, we are just returning any errors and no values right? I'm assuming the solana manager doesn't have any sort of transaction receipt or a blockhash to confirm that the transaction has finalized.
|
What are the next steps here? How can we move this forward? |
|
I was hoping to discuss as a parking lot item today, we can merge the current design and only handle success route for now. Failure handling will require one of the suggested solutions which will need changes outside the write target |
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
No description provided.