Skip to content

Commit

Permalink
Remove spurious warning (#93)
Browse files Browse the repository at this point in the history
  • Loading branch information
samsondav authored Dec 16, 2024
1 parent 1f5c6b2 commit fa030d1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions llo/plugin_outcome.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,11 @@ func (p *Plugin) outcome(outctx ocr3types.OutcomeContext, query types.Query, aos
for _, strm := range cd.Streams {
sid, agg := strm.StreamID, strm.Aggregator
if _, exists := outcome.StreamAggregates[sid][agg]; exists {
p.Logger.Warnw("Invariant violation: unexpected duplicate stream/aggregator pair", "channelID", cid, "streamID", sid, "aggregator", agg, "stage", "Outcome", "seqNr", outctx.SeqNr)
// Should only happen in the unexpected case of duplicate
// streams, no need to aggregate twice
// Should only happen in the case of duplicate
// streams, no need to aggregate twice.
//
// This isn't an error, its possible for report formats to
// specify the same stream multiple times if they wish.
continue
}
aggF := GetAggregatorFunc(agg)
Expand Down

0 comments on commit fa030d1

Please sign in to comment.