update go.mod replaces #386
Conversation
jmank88
requested review from
reductionista,
cfal and
ilija42
and removed request for
reductionista
|
SonarQube Quality Gate
|
|
damn, integration tests are failing again. |
There was a problem hiding this comment.
it seems related to the ChainReader stuff: https://github.com/smartcontractkit/chainlink-cosmos/actions/runs/7114275441/job/19367994022?pr=386
i guess pointing it to the same ref as the last PR should get it to pass?
It would be better if you just edit the description of this PR to include this text: core ref: BCF-2612-ChainReader-EVM-POC Then I can update the go.mod in the chainlink PR to point to this reference instead of the previous one, before merging? |
Just realized I can edit it myself... weird. Went ahead and added it, so hopefully it will go green now |
|
yep, editing the description causes the test run to restart. didn't know anyone could edit though, cool :) |
wouldn't the hash change once this PR gets merged into develop? |
Because it's only a single commit, "sqash and merge" won't change the commit hash. It does generate an empty merge commit on top of it, but that shouldn't matter. Although it's moot anyway, since I'm going to merge this one and then update the hash immediately after. |
|
@cfal You were right actually, it did change the commit hash. For some reason it worked when I merged the starknet PR, but not this one: Must be different settings for these repos I guess? Anyway, the hash is pointing to the merged one now. |
Following #379, I noticed these go.mod replaces are stale.
core ref: BCF-2612-ChainReader-EVM-POC