Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/cosmos: move tx and chain from core #381

Merged
merged 1 commit into from
Nov 1, 2023
Merged

pkg/cosmos: move tx and chain from core #381

merged 1 commit into from
Nov 1, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 31, 2023 •
edited
Loading

@jmank88 jmank88 mentioned this pull request Oct 31, 2023
Merged
cfal
cfal reviewed Nov 1, 2023
View reviewed changes
pkg/cosmos/txm/orm.go
)

type DB interface {
BeginTxx(context.Context, *sql.TxOptions) (*sqlx.Tx, error)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BeginTx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sqlx variant that we use in core. IIUC they couldn't override BeginTx while returning a different Tx type, so they suffixed with x. Bad luck that Tx also ends in x in this case 🤷

@jmank88 jmank88 force-pushed the BCI-900-mv-txm-chain branch 2 times, most recently from 6a088d2 to e57032d Compare November 1, 2023 13:25
@jmank88 jmank88 force-pushed the BCI-900-mv-txm-chain branch from e57032d to 3d0eb7a Compare November 1, 2023 13:29
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 marked this pull request as ready for review November 1, 2023 13:52
@aalu1418
Copy link
Collaborator

aalu1418 commented Nov 1, 2023

merging to unblock cosmos extraction work in core - CI will continue to fail

@aalu1418 aalu1418 merged commit 7acebcc into develop Nov 1, 2023
9 of 16 checks passed
@aalu1418 aalu1418 deleted the BCI-900-mv-txm-chain branch November 1, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@krehermann krehermann krehermann approved these changes

@cfal cfal cfal approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @aalu1418 @cfal @krehermann