Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-2685: move types from core to support Solana plugin command extraction #193

Merged
merged 1 commit into from
Oct 20, 2023
Merged

BCF-2685: move types from core to support Solana plugin command extraction #193

merged 1 commit into from
Oct 20, 2023

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Oct 9, 2023 •
edited
Loading

@jmank88 jmank88 temporarily deployed to integration October 9, 2023 11:50 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 9, 2023 11:50 — with GitHub Actions Inactive
jmank88
jmank88 commented Oct 9, 2023
View reviewed changes
pkg/loop/config.go Outdated Show resolved Hide resolved
jmank88
jmank88 commented Oct 9, 2023
View reviewed changes
pkg/loop/prom.go Outdated Show resolved Hide resolved
krehermann
krehermann reviewed Oct 9, 2023
View reviewed changes
pkg/loop/prom.go Outdated Show resolved Hide resolved
pkg/loop/prom_test.go Outdated Show resolved Hide resolved
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 1809045 to eb035bc Compare October 10, 2023 13:29
@jmank88 jmank88 temporarily deployed to integration October 10, 2023 13:29 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 10, 2023 13:29 — with GitHub Actions Inactive
@jmank88 jmank88 mentioned this pull request Oct 10, 2023
Merged
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from eb035bc to 0b72221 Compare October 16, 2023 17:30
@jmank88 jmank88 temporarily deployed to integration October 16, 2023 17:30 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 0b72221 to 9fd5f3b Compare October 16, 2023 17:34
@jmank88 jmank88 temporarily deployed to integration October 16, 2023 17:35 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 16, 2023 17:35 — with GitHub Actions Inactive
@jmank88 jmank88 mentioned this pull request Oct 16, 2023
Merged
@jmank88 jmank88 requested a review from aalu1418 October 16, 2023 19:59
@jmank88 jmank88 changed the title move types from core to support Solana plugin command extraction BCF-2685: move types from core to support Solana plugin command extraction Oct 16, 2023
patrickhuie19
patrickhuie19 previously approved these changes Oct 16, 2023
View reviewed changes
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 9fd5f3b to 1b0e988 Compare October 17, 2023 15:57
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 15:57 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 15:57 — with GitHub Actions Inactive
@jmank88 jmank88 mentioned this pull request Oct 18, 2023
Merged
@jmank88
Copy link
Collaborator Author

jmank88 commented Oct 19, 2023

This is ready for review, although no rush since I should wait and rebase after these are merged:

jmank88
jmank88 commented Oct 19, 2023
View reviewed changes
pkg/loop/adapter.go Outdated Show resolved Hide resolved
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from b4fc523 to b2585cc Compare October 19, 2023 12:53
@jmank88 jmank88 temporarily deployed to integration October 19, 2023 12:53 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 19, 2023 12:53 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from b2585cc to bbc232e Compare October 20, 2023 20:06
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 20:06 — with GitHub Actions Inactive
jmank88
jmank88 commented Oct 20, 2023
View reviewed changes
pkg/loop/config.go Outdated Show resolved Hide resolved
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from bbc232e to 7a73072 Compare October 20, 2023 21:18
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 21:18 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 21:18 — with GitHub Actions Inactive
patrickhuie19
patrickhuie19 previously approved these changes Oct 20, 2023
View reviewed changes
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 7a73072 to 787e5d7 Compare October 20, 2023 22:18
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 22:19 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 22:19 — with GitHub Actions Inactive
@jmank88 jmank88 merged commit 2ede955 into main Oct 20, 2023
6 of 8 checks passed
@jmank88 jmank88 deleted the BCF-2685-solana-loopp-extraction branch October 20, 2023 23:03
@jmank88
Copy link
Collaborator Author

jmank88 commented Oct 20, 2023

Merged to unblock the growing stack of PRs, but I'm happy to circle back on anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@aalu1418 aalu1418 Awaiting requested review from aalu1418

@krebernisak krebernisak Awaiting requested review from krebernisak

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @krehermann @patrickhuie19