Fix coverage report workflow step #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
commented
Aug 30, 2024
| @@ -35,16 +35,14 @@ jobs: | |||
| - name: Generate coverage report | |||
| if: github.event_name == 'pull_request' | |||
| run: | | |||
| go tool cover -func=coverage.out > coverage.txt | |||
dimkouv
commented
Aug 30, 2024
| total=$(go tool cover -func=coverage.out | grep total | awk '{print $3}') | ||
| echo "coverage=$total" >> $GITHUB_ENV | ||
| - name: Coverage on target branch | ||
| if: github.event_name == 'pull_request' | ||
| run: | | ||
| git fetch origin ${{ github.base_ref }} | ||
| git checkout ${{ github.base_ref }} | ||
| go test -coverprofile=coverage_target.out ./... | ||
| go tool cover -func=coverage_target.out > coverage_target.txt | ||
| TEST_COUNT=1 COVERAGE_FILE=coverage_target.out make test |
There was a problem hiding this comment.
use same test strategy as in branch test run
Test Coverage
|
asoliman92
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the coverage report workflow step was not using
make testfor the target branch but a simplego test. Recentlymake testwas updated leading to wrong coverage reports.