internal/reader: add GetExpectedNextSequenceNumber method #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
reviewed
Aug 27, 2024
internal/reader/ccip.go
Outdated
| // in the onramp. | ||
| GetExpectedNextSequenceNumber( | ||
| ctx context.Context, | ||
| sourceChainSelector cciptypes.ChainSelector, |
There was a problem hiding this comment.
I thought we were going to stop using the implicit destination:
Suggested change
| sourceChainSelector cciptypes.ChainSelector, | |
| source, dest cciptypes.ChainSelector, |
There was a problem hiding this comment.
Good catch, done.
dimkouv
approved these changes
Aug 27, 2024
| } | ||
|
|
||
| if err := r.validateReaderExistence(sourceChainSelector); err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
We have a ticket for this I want to tackle next: https://smartcontract-it.atlassian.net/browse/CCIP-3071
Test Coverage
|
makramkd
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 27, 2024
## Motivation We want to add a test for GetExpectedNextSequenceNumber in ccipreader_test.go Related PR: smartcontractkit/chainlink-ccip#81 ## Solution Add a test for GetExpectedNextSequenceNumber in ccipreader_test.go
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 28, 2024
We want to add a test for GetExpectedNextSequenceNumber in ccipreader_test.go Related PR: smartcontractkit/chainlink-ccip#81 Add a test for GetExpectedNextSequenceNumber in ccipreader_test.go
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 28, 2024
We want to add a test for GetExpectedNextSequenceNumber in ccipreader_test.go Related PR: smartcontractkit/chainlink-ccip#81 Add a test for GetExpectedNextSequenceNumber in ccipreader_test.go
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 28, 2024
We want to add a test for GetExpectedNextSequenceNumber in ccipreader_test.go Related PR: smartcontractkit/chainlink-ccip#81 Add a test for GetExpectedNextSequenceNumber in ccipreader_test.go
AnieeG
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 28, 2024
## Motivation We want to add a test for GetExpectedNextSequenceNumber in ccipreader_test.go Related PR: smartcontractkit/chainlink-ccip#81 ## Solution Add a test for GetExpectedNextSequenceNumber in ccipreader_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test in core: smartcontractkit/ccip#1373
The commit plugin currently builds merkle roots of size one because it only reads offramp sequence numbers. Add this so it can read onramp sequence numbers as well