Initialize nonce manager. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
force-pushed
the
will/8-nonces-reader
branch
from
cc4684f to
338b35f
Compare
asoliman92
reviewed
Aug 26, 2024
asoliman92
reviewed
Aug 26, 2024
| return resp, nil | ||
| } | ||
|
|
||
| type offrampStaticChainConfig struct { |
There was a problem hiding this comment.
Can you put link to the offramp type? Will make it easier to find it.
There was a problem hiding this comment.
Yeah, what did you have in mind? A comment? I copied the pattern used for type sourceChainConfig struct {, so I'll update that as well.
There was a problem hiding this comment.
A permalink to the solidity struct would be good enough IMO
makramkd
reviewed
Aug 27, 2024
Comment on lines
+627
to
+719
| ChainSelector uint64 `json:"chainSelector"` | ||
| RmnProxy []byte `json:"rmnProxy"` | ||
| TokenAdminRegistry []byte `json:"tokenAdminRegistry"` | ||
| NonceManager []byte `json:"nonceManager"` |
There was a problem hiding this comment.
json tags should not be required
winder
force-pushed
the
will/8-nonces-reader
branch
from
338b35f to
207ea30
Compare
Co-authored-by: Makram <[email protected]> Co-authored-by: Abdelrahman Soliman (Boda) <[email protected]>
makramkd
approved these changes
Aug 28, 2024
| return nil | ||
| } | ||
|
|
||
| func (r *CCIPChainReader) Sync(ctx context.Context) (bool, error) { |
There was a problem hiding this comment.
@dimkouv why the (bool, error) return signature? I feel like error is enough?
| return resp, nil | ||
| } | ||
|
|
||
| type offrampStaticChainConfig struct { |
There was a problem hiding this comment.
A permalink to the solidity struct would be good enough IMO
Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bindings for the NonceManager and finish implementing the CCIPReader.