Move execute types to exectypes package. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
force-pushed
the
will/5-exectypes
branch
2 times, most recently
from
a9277f8 to
795cfb8
Compare
makramkd
approved these changes
Aug 7, 2024
| @@ -0,0 +1,32 @@ | |||
| package exectypes | |||
There was a problem hiding this comment.
I'm indifferent but why not just types and have an import alias to make it exectypes? I'm not crazy about it because it kinda makes imports harder (my IDE doesn't do auto-aliasing and there are a ton of packages called types already)
There was a problem hiding this comment.
Thats exactly why I wanted exec in the package name. There are so many types packages already and the aliases are often slightly different.
asoliman92
approved these changes
Aug 9, 2024
mateusz-sekara
approved these changes
Aug 9, 2024
winder
force-pushed
the
will/5-exectypes
branch
from
795cfb8 to
de29f46
Compare
Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid needing
ExecutePluginprefixes on all exec plugin types, move types fromplugintypespackage to a newexectypespackage.There are no functional changes in this PR.
These changes are built ontop of #56