[Solana]: Fix fee calculations + add validated test values #427
+170
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toblich
previously approved these changes
Jan 9, 2025
| @@ -356,14 +356,22 @@ impl Solana2AnyMessage { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Is this still flagged as dead code by the linter, or could we remove the attribute?
There was a problem hiding this comment.
Ah I missed this, sorry!
PabloMansanet
force-pushed
the
network_fee_fixes_and_validated_tests
branch
from
fdf9c63 to
fe2c7f8
Compare
|
toblich
approved these changes
Jan 10, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.