CCIP-4710: Adding nil and length check on input value to Ed25519 verify call #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-gopalswami
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
b-gopalswami
commented
Dec 20, 2024
Comment on lines
+50
to
+55
| if rmnNode.OffchainPublicKey == nil { | ||
| return fmt.Errorf("node %d has no offchain public key", rmnNode.ID) | ||
| } | ||
| if len(*rmnNode.OffchainPublicKey) != ed25519.PublicKeySize { | ||
| return fmt.Errorf("node %d has an invalid offchain public key", rmnNode.ID) | ||
| } |
There was a problem hiding this comment.
These are the key changes. As OffchainPublicKey is required, test needs to be updated.
winder
approved these changes
Dec 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure public key is not nil and length is accurate before verifying it.