Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-4712: Adding nil check to address CL33-16 finding #399

Merged
merged 7 commits into from
Dec 20, 2024
Merged

CCIP-4712: Adding nil check to address CL33-16 finding #399

merged 7 commits into from
Dec 20, 2024

Conversation

b-gopalswami
Copy link
Collaborator

Adding nil check in couple of spots.

@b-gopalswami b-gopalswami requested a review from a team as a code owner December 20, 2024 15:35
@b-gopalswami b-gopalswami changed the title Adding nil check to address CL33-16 finding CCIP-4712: Adding nil check to address CL33-16 finding Dec 20, 2024
asoliman92
asoliman92 reviewed Dec 20, 2024
View reviewed changes
pkg/reader/ccip.go Outdated Show resolved Hide resolved
winder
winder approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

Metric cl33-16 main
Coverage 76.5% 76.5%

@winder winder merged commit 8f67f1c into main Dec 20, 2024
17 checks passed
@winder winder deleted the cl33-16 branch December 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asoliman92 asoliman92 asoliman92 left review comments

@winder winder winder approved these changes

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-gopalswami @winder @asoliman92