No panic on new request id #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
requested review from
winder,
rstout,
asoliman92,
makramkd,
mateusz-sekara,
0xAustinWang and
0xnogo
winder
reviewed
Dec 20, 2024
commit/merkleroot/rmn/controller.go
Outdated
| "atomicCounter", atomicCounter.Load(), | ||
| ) | ||
| t := time.Now().UTC().UnixNano() | ||
| c := atomicCounter.Add(1) |
There was a problem hiding this comment.
The end of the timestamp has the most entropy, it would be better to include the counter at the front.
Not sure this is strictly correct, but I'm thinking something like this
b := make([]byte, 8)
binary.BigEndian.PutInt64(b, t)
b[0]=byte(c%256)
winder
approved these changes
Dec 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newRequestID()might panic in some very rare case scenarios. Add some handling to prevent the panic.