Don't observe destChain fee #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asoliman92
commented
Dec 19, 2024
•
asoliman92
commented
- Don't observe destChain fee
- Fix test setup
asoliman92
requested review from
winder,
rstout,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
0xnogo
previously approved these changes
Dec 19, 2024
… returned set will affect the original set
asoliman92
commented
Dec 19, 2024
| @@ -87,7 +87,7 @@ func (c ccipChainSupport) SupportedChains(oracleID commontypes.OracleID) (mapset | |||
| return mapset.NewSet[cciptypes.ChainSelector](), fmt.Errorf("error getting supported chains: %w", err) | |||
| } | |||
|
|
|||
| return supportedChains, nil | |||
| return supportedChains.Clone(), nil | |||
There was a problem hiding this comment.
Return a clone from supported chains. Otherwise any operations on the returned set will affect the original set
asoliman92
commented
Dec 19, 2024
| @@ -438,11 +438,11 @@ func TestPlugin_E2E_AllNodesAgree_ChainFee(t *testing.T) { | |||
| nodes := make([]ocr3types.ReportingPlugin[[]byte], len(oracleIDs)) | |||
There was a problem hiding this comment.
changing the tests to simulate real results as we shouldn't expect fees for the destChain itself.
|
dimkouv
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.