Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RMN contracts breaking changes [CCIP-4590] #379

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

asoliman92
Copy link
Contributor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@dimkouv dimkouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's review offchain f aswell.
e.g.

// GetF gets the F value for each source chain in the given configDigest.
	// Maximum number of faulty observers; F+1 observers required to agree on an observation for a source chain.
	GetF(configDigest cciptypes.Bytes32) (map[cciptypes.ChainSelector]int, error)
	```
	
	to `GetFObserve()`

@asoliman92 asoliman92 requested a review from dimkouv December 18, 2024 12:54
dimkouv and others added 2 commits December 19, 2024 17:24
Copy link

github-actions bot commented Jan 7, 2025

Metric rmn-breaking-changes main
Coverage 76.5% 76.5%

@asoliman92 asoliman92 merged commit 48a464f into main Jan 7, 2025
17 checks passed
@mateusz-sekara mateusz-sekara deleted the rmn-breaking-changes branch January 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants