Fix Logical Bug in isStaleReport Function

[dimkouv]

Pull Request: Fix Logical Bug in isStaleReport Function

Problem

The isStaleReport function contained a logical bug when comparing the on-chain sequence number (seqNr) with the report sequence number (latestSeqNr). The incorrect logic caused certain reports to be accepted and transmitted, leading to on-chain reverts.

Original (Buggy) Logic

if seqNr < latestSeqNr && len(decodedReport.MerkleRoots) == 0 {

Corrected Logic

if seqNr <= latestSeqNr && len(decodedReport.MerkleRoots) == 0 {

Issue Details

• Bug: The condition seqNr < latestSeqNr was too restrictive, failing to account for cases where seqNr equals latestSeqNr.
• Impact: Reports were incorrectly flagged as valid, causing unnecessary transmissions and on-chain reverts.

Fix

The condition is updated to include equality (<=) to ensure the comparison correctly identifies stale reports:

if seqNr <= latestSeqNr && len(decodedReport.MerkleRoots) == 0 {

Testing and Validation

• Added/updated unit tests to verify the new logic.
• Tested against scenarios that previously caused on-chain reverts to ensure the issue is resolved.

Additional Notes

• This fix aligns the function's behavior with the intended logic for identifying stale reports.
• Please review and confirm if additional edge cases should be considered.

[github-actions]

Metric	dk/fix-stale-report-checks	main
Coverage	76.8%	76.7%