Bump common and fix Chain Writer naming #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2024
jmank88
previously approved these changes
Nov 27, 2024
ilija42
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
|
Did CI get stuck? |
jmank88
reviewed
Dec 2, 2024
Oh, or are the required CI jobs hard-coded with a Go version |
seems like it |
jmank88
reviewed
Dec 3, 2024
Comment on lines
+34
to
+37
| gosec: | ||
| # TODO - remove this and fix linter complaint | ||
| excludes: | ||
| - G115 |
There was a problem hiding this comment.
How many were there? It would be a little better to mark them directly as //nolint:gosec // G115 .... if it's not too much trouble.
jmank88
reviewed
Dec 3, 2024
|
|
||
| ensure_golangcilint_1_59: | ||
| @golangci-lint --version | grep -q '1.59' || (echo "Please use golangci-lint 1.59" && exit 1) | ||
| ensure_golangcilint_1_62_2: |
There was a problem hiding this comment.
Does this pattern serve a purpose? Or could we drop it?
Suggested change
| ensure_golangcilint_1_62_2: | |
| ensure_golangcilint_version: |
|
winder
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: fa346afd62ef6f6f97b18ddae4eee2298ebc5001