Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Convert Gas price in USD" #300

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

makramkd
Copy link
Collaborator

@makramkd makramkd commented Nov 6, 2024

Reverts #290

This is causing the smoke test TestInitialDeployOnLocal to fail due to exec filtering out costly messages. In order to unblock other PRs, just going to revert this for now to allow it to get debugged properly.

Core PR smartcontractkit/chainlink#15134

Copy link

github-actions bot commented Nov 6, 2024

Metric revert-290-ng/convert-gas-usd main
Coverage 73.7% 73.6%

@makramkd makramkd marked this pull request as ready for review November 6, 2024 14:00
@makramkd makramkd requested a review from a team as a code owner November 6, 2024 14:00
@makramkd makramkd merged commit 4c9ee21 into main Nov 6, 2024
3 of 4 checks passed
0xnogo added a commit that referenced this pull request Nov 7, 2024
@mateusz-sekara mateusz-sekara deleted the revert-290-ng/convert-gas-usd branch November 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants