Test commit plugin Reports #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
requested review from
winder,
rstout,
asoliman92,
makramkd,
mateusz-sekara and
0xnogo
dimkouv
commented
Nov 1, 2024
| @@ -40,10 +40,13 @@ func (p *Plugin) Reports( | |||
| return nil, fmt.Errorf("failed to decode Outcome (%s): %w", hex.EncodeToString(outcomeBytes), err) | |||
| } | |||
|
|
|||
| // Until we start adding tokens and gas to the report, we don't need to report anything | |||
There was a problem hiding this comment.
This comment seemed wrong to me.
dimkouv
commented
Nov 1, 2024
| @@ -60,6 +63,11 @@ func (p *Plugin) Reports( | |||
| RMNSignatures: outcome.MerkleRootOutcome.RMNReportSignatures, | |||
| } | |||
|
|
|||
| if rep.IsEmpty() { | |||
There was a problem hiding this comment.
If report is empty skip the steps below.
0xnogo
approved these changes
Nov 1, 2024
|
makramkd
reviewed
Nov 4, 2024
| @@ -40,10 +40,13 @@ func (p *Plugin) Reports( | |||
| return nil, fmt.Errorf("failed to decode Outcome (%s): %w", hex.EncodeToString(outcomeBytes), err) | |||
| } | |||
|
|
|||
| // Until we start adding tokens and gas to the report, we don't need to report anything | |||
| // Gas prices and token prices do not need to get reported when merkle roots do not exist. | |||
There was a problem hiding this comment.
I don't think this is correct, sources may not have merkle roots but the dest needs source gas prices + token prices in order to bill for requests from dest -> rest of chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.