Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fully qualified service names #286

Merged
merged 4 commits into from
Nov 1, 2024
Merged

use fully qualified service names #286

merged 4 commits into from
Nov 1, 2024
+2 −2

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Oct 31, 2024 •
edited
Loading

Updating Name() to return the logger name
https://pkg.go.dev/github.com/smartcontractkit/[email protected]/pkg/services#HealthReporter

// Name returns the fully qualified name of the component. Usually the logger name.

@jmank88 jmank88 requested a review from a team as a code owner October 31, 2024 16:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Metric service-names main
Coverage 72.5% 72.4%

@jmank88 jmank88 merged commit 86885ce into main Nov 1, 2024
3 of 4 checks passed
@jmank88 jmank88 deleted the service-names branch November 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @makramkd