Add e2e plugin test for chainfee #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustinWang
changed the title
0xAustinWang
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
dimkouv
approved these changes
Oct 29, 2024
winder
reviewed
Oct 29, 2024
winder
reviewed
Oct 29, 2024
Comment on lines
+509
to
+511
| destChain: newNativePrice, | ||
| sourceChain1: newNativePrice, | ||
| sourceChain2: newNativePrice, |
There was a problem hiding this comment.
The assertions would be a lot easier to read if the parameter was these prices rather than the prices and all the expectations
winder
reviewed
Oct 29, 2024
commit/plugin_e2e_test.go
Outdated
| n := setupNode(params, oracleIDs[i]) | ||
| nodes[i] = n.node | ||
|
|
||
| prepareCcipReaderMock( |
There was a problem hiding this comment.
I guess you could add the fee components as arguments to this function
There was a problem hiding this comment.
the fee components are on a different reader, but i added a function for those
winder
reviewed
Oct 29, 2024
winder
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
This looks about right, but I'm not familiar enough with the chainfee logic to tell if you missed anything.
Left a couple suggestions that would help clarify the tests. It would also be helpful to leave a few extra comments for each test that explain why the inputs result in the expected outcome.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CCIP-3984