Don't panic when decoding empty slice. (#383)

smartcontractkit · Dec 19, 2024 · f9157a7 · f9157a7
1 parent 67e180e
commit f9157a7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/pkg/types/ccipocr3/plugin_execute_types.go b/pkg/types/ccipocr3/plugin_execute_types.go
@@ -33,6 +33,10 @@ func (eri ExecuteReportInfo) Encode() ([]byte, error) {
 // DecodeExecuteReportInfo is a version aware decode function for the execute
 // report info bytes.
 func DecodeExecuteReportInfo(data []byte) (ExecuteReportInfo, error) {
+	if len(data) == 0 {
+		return ExecuteReportInfo{}, nil
+	}
+
 	switch data[0] {
 	case 1:
 		var result ExecuteReportInfo

diff --git a/pkg/types/ccipocr3/plugin_execute_types_test.go b/pkg/types/ccipocr3/plugin_execute_types_test.go
@@ -28,6 +28,13 @@ func TestDecodeExecuteReportInfo(t *testing.T) {
 		_, err := DecodeExecuteReportInfo(data)
 		require.ErrorContains(t, err, "object") // not super helpful...
 	}
+
+	// empty
+	{
+		ri, err := DecodeExecuteReportInfo(nil)
+		require.NoError(t, err)
+		require.Equal(t, ExecuteReportInfo{}, ri)
+	}
 }
 
 func TestExecuteReportInfo_EncodeDecode(t *testing.T) {