Deterministic custom transmission schedule (#378)

smartcontractkit · Dec 18, 2024 · f742191 · f742191
1 parent 5dc5b13
commit f742191
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/internal/plugincommon/transmitters.go b/internal/plugincommon/transmitters.go
@@ -2,6 +2,7 @@ package plugincommon
 
 import (
 	"fmt"
+	"sort"
 	"time"
 
 	"github.com/smartcontractkit/libocr/commontypes"
@@ -33,6 +34,9 @@ func GetTransmissionSchedule(
 		}
 	}
 
+	// transmissionSchedule must be deterministic
+	sort.Slice(transmitters, func(i, j int) bool { return transmitters[i] < transmitters[j] })
+
 	transmissionDelays := make([]time.Duration, len(transmitters))
 
 	for i := range transmissionDelays {

diff --git a/internal/plugincommon/transmitters_test.go b/internal/plugincommon/transmitters_test.go
@@ -50,6 +50,15 @@ func TestGetTransmissionSchedule(t *testing.T) {
 			expectedError:               true,
 			chainSupportReturnsError:    true,
 		},
+		{
+			name:                        "determinism check",
+			allTheOracles:               []commontypes.OracleID{3, 1, 2}, // <------ not ordered
+			oraclesSupportingDest:       []commontypes.OracleID{1, 3},
+			transmissionDelayMultiplier: 5 * time.Second,
+			expectedTransmitters:        []commontypes.OracleID{1, 3},
+			expectedTransmissionDelays:  []time.Duration{5 * time.Second, 10 * time.Second},
+			expectedError:               false,
+		},
 	}
 
 	for _, tc := range testCases {