Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not read res if http errors #676

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Do not read res if http errors #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34e24f4
do not read res if http errors
matYang Apr 2, 2024
2531bbc
changeset
matYang Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-suns-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ccip": patch
---

Do not read res if http errors
2 changes: 1 addition & 1 deletion core/services/ocr2/plugins/ccip/tokendata/http/http_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func (s *HttpClient) Get(ctx context.Context, url string, timeout time.Duration)
return nil, http.StatusRequestTimeout, nil, tokendata.ErrTimeout
}
// On error, res is nil in most cases, do not read res.StatusCode, return BadRequest
return nil, http.StatusBadRequest, res.Header, err
return nil, http.StatusBadRequest, nil, err
}
defer res.Body.Close()

Expand Down
Loading