Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny golf #661

Merged
merged 4 commits into from
Mar 29, 2024
Merged

tiny golf #661

merged 4 commits into from
Mar 29, 2024

Conversation

RensR
Copy link
Collaborator

@RensR RensR commented Mar 29, 2024

Motivation

Solution

@RensR RensR requested review from matYang and makramkd as code owners March 29, 2024 14:36
@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 216e93b during Solidity Foundry #3336

Summary coverage rate:
  lines......: 98.7% (975 of 988 lines)
  functions..: 95.7% (201 of 210 functions)
  branches...: 91.6% (383 of 418 branches)

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@makramkd
Copy link
Contributor

Looks good, just need to run a FOUNDRY_PROFILE=ccip make wrappers

@RensR RensR requested a review from a team as a code owner March 29, 2024 16:11
@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 097b057 during Solidity Foundry #3338

Summary coverage rate:
  lines......: 98.7% (975 of 988 lines)
  functions..: 95.7% (201 of 210 functions)
  branches...: 91.6% (383 of 418 branches)

Files changed coverage rate: n/a

@makramkd makramkd merged commit a336379 into makram/ethsendrecv Mar 29, 2024
41 of 43 checks passed
@makramkd makramkd deleted the golf branch March 29, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@matYang matYang Awaiting requested review from matYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RensR @makramkd