Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC impl of blue-chip-only aggregate rate limit #184

Closed
wants to merge 1 commit into from

Conversation

matYang
Copy link
Collaborator

@matYang matYang commented Oct 3, 2023

Only consume aggregate rate limit if a token is marked to do so, e.g. with bps > 0 in this POC. In practice it should be a standalone config param.

POC solution passes the flag from OnRamp to OffRamp in sourceTokenData to avoid adding mirroring config params at OffRamp.

@matYang matYang added the do not merge Do not merge at this time label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

LCOV of commit e40dac4 during Solidity Foundry #802

Summary coverage rate:
  lines......: 98.9% (929 of 939 lines)
  functions..: 96.4% (190 of 197 functions)
  branches...: 90.3% (365 of 404 branches)

Files changed coverage rate: n/a

@matYang matYang changed the title POC impl of blue-chip-only aggregate rate limit (not pretty) POC impl of blue-chip-only aggregate rate limit Oct 4, 2023
@matYang
Copy link
Collaborator Author

matYang commented Oct 12, 2023

Discarding this in favor of explicit configuration on the destination chain

@matYang matYang closed this Oct 12, 2023
@matYang matYang deleted the aggr-rate-limit-blue-chip-only branch October 19, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge at this time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant