CCIP-4403 don't request lbtc attestation if payload is returned #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if len(destTokenData) != 32 { | ||
| s.lggr.Infow("SourceTokenData.extraData size is not 32. This is deposit payload, not sha256(payload). Attestation is disabled onchain", | ||
| "destTokenData", hexutil.Encode(destTokenData)) | ||
| return destTokenData, nil |
There was a problem hiding this comment.
Why are we returning destTokenData here instead of an error signaling unexpected input?
There was a problem hiding this comment.
Because this is expected input
in destTokenData Lombard can send to us either full payload (if attestation is disabled) either sha256(payload)
In first case we won't call attestation at all
NourElRashidy
approved these changes
Dec 3, 2024
rstout
approved these changes
Dec 3, 2024
bukata-sa
added a commit
that referenced
this pull request
Dec 6, 2024
Lombard send full payload if attestation is disabled. It can be enabled by redeploying token pools and synchronizing this between chains. If mistake took place and we got a message with full payload while attestation is enabled onchain at Lombard side, message will be available for manual exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lombard send full payload if attestation is disabled. It can be enabled by redeploying token pools and synchronizing this between chains.
If mistake took place and we got a message with full payload while attestation is enabled onchain at Lombard side, message will be available for manual exec