Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set FinalityTagBypass=false for chains with FinalityDepth<1k #1526

Merged
merged 6 commits into from
Dec 13, 2024
Merged

set FinalityTagBypass=false for chains with FinalityDepth<1k #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26a315b
set FinalityTagBypass=false for chains with FinalityDepth<1k
Madalosso Nov 8, 2024
9013e5e
Merge remote-tracking branch 'origin/ccip-develop' into madalosso/fin…
friedemannf Dec 13, 2024
862508b
Merge remote-tracking branch 'refs/remotes/origin/ccip-develop' into …
friedemannf Dec 13, 2024
0c0d158
Also adjust other chains
friedemannf Dec 13, 2024
96e29ef
Link to ticket instead
friedemannf Dec 13, 2024
8fe35e5
fix tests
friedemannf Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ccip/config/evm/Astar_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,9 @@ LogPollInterval = '6s'
[GasEstimator]
EIP1559DynamicFees = false
PriceMax = '100000 gwei'
LimitDefault = 8000000
LimitDefault = 8000000

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
7 changes: 6 additions & 1 deletion ccip/config/evm/Astar_Shibuya.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,9 @@ LogPollInterval = '6s'
[GasEstimator]
EIP1559DynamicFees = false
PriceMax = '100000 gwei'
LimitDefault = 8000000
LimitDefault = 8000000

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions ccip/config/evm/Avalanche_ANZ_testnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@ PriceMin = '25 gwei'

[GasEstimator.BlockHistory]
BlockHistorySize = 24

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions ccip/config/evm/Avalanche_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@ PriceMin = '25 gwei'
[GasEstimator.BlockHistory]
# Average block time of 2s
BlockHistorySize = 24

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions ccip/config/evm/BSC_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,8 @@ ObservationGracePeriod = '500ms'

[NodePool]
SyncThreshold = 10

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/Base_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ ResendAfterThreshold = '30s'

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Base_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ ResendAfterThreshold = '30s'

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Blast_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ EIP1559FeeCapBufferBlocks = 0

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
# 4 block sync time between nodes to ensure they aren't labelled unreachable too soon
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Blast_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ EIP1559FeeCapBufferBlocks = 0

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
# 4 block sync time between nodes to ensure they aren't labelled unreachable too soon
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Celo_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ BlockHistorySize = 12

[HeadTracker]
HistoryDepth = 50
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions ccip/config/evm/Gnosis_Chiado.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@ NoNewFinalizedHeadsThreshold = '2m'
[GasEstimator]
EIP1559DynamicFees = true
PriceMax = '500 gwei'

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/Kroma_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ ResendAfterThreshold = '30s'

[HeadTracker]
HistoryDepth = 400
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Kroma_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ ResendAfterThreshold = '30s'

[HeadTracker]
HistoryDepth = 400
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
Expand Down
5 changes: 5 additions & 0 deletions ccip/config/evm/L3X_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,8 @@ PriceMin = '0'
PriceDefault = '0.1 gwei'
FeeCapDefault = '1000 gwei'
BumpThreshold = 5

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions ccip/config/evm/L3X_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,8 @@ PriceMin = '0'
PriceDefault = '0.1 gwei'
FeeCapDefault = '1000 gwei'
BumpThreshold = 5

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/Linea_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ ResendAfterThreshold = '3m'
# set greater than finality depth
[HeadTracker]
HistoryDepth = 350
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 4 additions & 1 deletion ccip/config/evm/Linea_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ PriceMin = '1 wei'
ResendAfterThreshold = '3m'

[HeadTracker]
HistoryDepth = 1000
HistoryDepth = 1000
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 4 additions & 1 deletion ccip/config/evm/Mantle_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@ MinIncomingConfirmations = 1

[HeadTracker]
HistoryDepth = 600
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[GasEstimator]
[GasEstimator]
Mode = 'L2Suggested'
PriceMax = '200 gwei'
LimitDefault = 100000000
Expand Down
5 changes: 5 additions & 0 deletions ccip/config/evm/Metis_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,8 @@ BlockHistorySize = 0

[NodePool]
SyncThreshold = 10

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions ccip/config/evm/Metis_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ BlockHistorySize = 0

[NodePool]
SyncThreshold = 10

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/Mode_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ EIP1559FeeCapBufferBlocks = 0

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
PollFailureThreshold = 2
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Mode_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ EIP1559FeeCapBufferBlocks = 0

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
PollFailureThreshold = 2
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Optimism_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ ResendAfterThreshold = '30s'

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Optimism_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ ResendAfterThreshold = '30s'

[HeadTracker]
HistoryDepth = 300
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
Expand Down
3 changes: 3 additions & 0 deletions ccip/config/evm/Polygon_Amoy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ BlockHistorySize = 24

[HeadTracker]
HistoryDepth = 2000
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
3 changes: 3 additions & 0 deletions ccip/config/evm/Polygon_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ BlockHistorySize = 24
[HeadTracker]
# Polygon suffers from a tremendous number of re-orgs, we need to set this to something very large to be conservative enough
HistoryDepth = 2000
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[NodePool]
SyncThreshold = 10
3 changes: 3 additions & 0 deletions ccip/config/evm/Polygon_Zkevm_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ BlockHistorySize = 12
[HeadTracker]
# Polygon suffers from a tremendous number of re-orgs, we need to set this to something very large to be conservative enough
HistoryDepth = 2000
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/Scroll_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ BlockHistorySize = 24

[HeadTracker]
HistoryDepth = 50
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[OCR]
ContractConfirmations = 1
3 changes: 3 additions & 0 deletions ccip/config/evm/Scroll_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ BlockHistorySize = 24

[HeadTracker]
HistoryDepth = 50
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[OCR]
ContractConfirmations = 1
3 changes: 3 additions & 0 deletions ccip/config/evm/Simulated.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ PriceMax = '100 micro'
HistoryDepth = 10
MaxBufferSize = 100
SamplingInterval = '0s'
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false

[OCR]
ContractConfirmations = 1
5 changes: 5 additions & 0 deletions ccip/config/evm/WeMix_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@ ContractConfirmations = 1
[GasEstimator]
EIP1559DynamicFees = true
TipCapDefault = '100 gwei'

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
2 changes: 2 additions & 0 deletions ccip/config/evm/WeMix_Testnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ EIP1559DynamicFees = true
TipCapDefault = '100 gwei'

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/XLayer_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ BlockHistorySize = 12

[HeadTracker]
HistoryDepth = 2000
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
3 changes: 3 additions & 0 deletions ccip/config/evm/XLayer_Sepolia.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ BlockHistorySize = 12

[HeadTracker]
HistoryDepth = 2000
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
7 changes: 6 additions & 1 deletion core/chains/evm/config/toml/defaults/Astar_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,9 @@ LogPollInterval = '6s'
[GasEstimator]
EIP1559DynamicFees = false
PriceMax = '100000 gwei'
LimitDefault = 8000000
LimitDefault = 8000000

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
7 changes: 6 additions & 1 deletion core/chains/evm/config/toml/defaults/Astar_Shibuya.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,9 @@ LogPollInterval = '6s'
[GasEstimator]
EIP1559DynamicFees = false
PriceMax = '100000 gwei'
LimitDefault = 8000000
LimitDefault = 8000000

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions core/chains/evm/config/toml/defaults/Avalanche_ANZ_testnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@ PriceMin = '25 gwei'

[GasEstimator.BlockHistory]
BlockHistorySize = 24

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
2 changes: 2 additions & 0 deletions core/chains/evm/config/toml/defaults/Avalanche_Fuji.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,6 @@ PriceMin = '25 gwei'
BlockHistorySize = 24

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions core/chains/evm/config/toml/defaults/Avalanche_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@ PriceMin = '25 gwei'
[GasEstimator.BlockHistory]
# Average block time of 2s
BlockHistorySize = 24

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
5 changes: 5 additions & 0 deletions core/chains/evm/config/toml/defaults/BOB_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,8 @@ CacheTimeout = '4s'

[GasEstimator.BlockHistory]
BlockHistorySize = 100

[HeadTracker]
# FinalityDepth < 1k => FinalityTagBypass = false
# https://smartcontract-it.atlassian.net/browse/SHIP-4078
FinalityTagBypass = false
Loading
Loading