Pool to support rebasing mint call #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
commented
Oct 7, 2024
| @@ -35,4 +33,8 @@ contract BurnWithFromMintTokenPool is BurnMintTokenPoolAbstract, ITypeAndVersion | |||
| function _burn(uint256 amount) internal virtual override { | |||
| IBurnMintERC20(address(i_token)).burn(address(this), amount); | |||
| } | |||
|
|
|||
| function typeAndVersion() external pure virtual override returns (string memory) { | |||
There was a problem hiding this comment.
The other way of writing it cannot be overridden
RensR
force-pushed
the
add-rebasing-pool
branch
from
2bf3b54 to
9783c12
Compare
LCOV of commit
|
RensR
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
RayXpub
approved these changes
Oct 8, 2024
0xsuryansh
approved these changes
Oct 8, 2024
elatoskinas
approved these changes
Oct 8, 2024
contracts/src/v0.8/ccip/test/pools/BurnWithFromMintRebasingTokenPool.t.sol
Outdated
Show resolved
Hide resolved
|
|
||
| function test_releaseOrMint_rebasing_success(uint16 multiplierPercentage) public { | ||
| uint256 amount = 1000; | ||
| uint256 expectedAmount = amount * multiplierPercentage / 100; |
There was a problem hiding this comment.
q: if percentage is 0, this should still succeed right because balancePost == balancePre and balancePost < balancePre does not fail?
There was a problem hiding this comment.
Is balancePost == balancePre desirable in the pool? It's basically a no balance increase
There was a problem hiding this comment.
Correct, I would call that case valid. The check is mostly there so 1) don't allow theft and 2) to not revert with an underflow when calculating the returned value
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basic pool supports rebasing minting