Do not read res if http errors (#676)

## Motivation ## Solution
smartcontractkit · Apr 2, 2024 · 996335a · 996335a
1 parent fce85a4
commit 996335a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/light-suns-build.md b/.changeset/light-suns-build.md
@@ -0,0 +1,5 @@
+---
+"ccip": patch
+---
+
+Do not read res if http errors
diff --git a/core/services/ocr2/plugins/ccip/tokendata/http/http_client.go b/core/services/ocr2/plugins/ccip/tokendata/http/http_client.go
@@ -34,7 +34,7 @@ func (s *HttpClient) Get(ctx context.Context, url string, timeout time.Duration)
 			return nil, http.StatusRequestTimeout, nil, tokendata.ErrTimeout
 		}
 		// On error, res is nil in most cases, do not read res.StatusCode, return BadRequest
-		return nil, http.StatusBadRequest, res.Header, err
+		return nil, http.StatusBadRequest, nil, err
 	}
 	defer res.Body.Close()