Zk Overflow in Execution Plugin (#947)

Changes to make the execution plugin overflow-compatible

.mockery.yaml

@@ -511,6 +511,9 @@ packages:
       PriceGetter:
         config:
           mockname: "Mock{{ .InterfaceName }}"
+  github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/statuschecker:
+    interfaces:
+      CCIPTransactionStatusChecker:
   github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/ccip/internal/rpclib:
     config:
       outpkg: rpclibmocks

core/services/ocr2/delegate.go

@@ -330,15 +330,15 @@ func (d *Delegate) cleanupEVM(ctx context.Context, jb job.Job, relayID types.Rel
 
 		dstProvider, err2 := d.ccipCommitGetDstProvider(ctx, jb, pluginJobSpecConfig, transmitterID)
 		if err2 != nil {
-			return err2
+			return err
 		}
 
 		srcProvider, _, err2 := d.ccipCommitGetSrcProvider(ctx, jb, pluginJobSpecConfig, transmitterID, dstProvider)
 		if err2 != nil {
-			return err2
+			return err
 		}
 		err2 = ccipcommit.UnregisterCommitPluginLpFilters(srcProvider, dstProvider)
-		if err != nil {
+		if err2 != nil {
 			d.lggr.Errorw("failed to unregister ccip commit plugin filters", "err", err2, "spec", spec)
 		}
 		return nil
@@ -353,12 +353,12 @@ func (d *Delegate) cleanupEVM(ctx context.Context, jb job.Job, relayID types.Rel
 
 		dstProvider, err2 := d.ccipExecGetDstProvider(ctx, jb, pluginJobSpecConfig, transmitterID)
 		if err2 != nil {
-			return err2
+			return err
 		}
 
 		srcProvider, _, err2 := d.ccipExecGetSrcProvider(ctx, jb, pluginJobSpecConfig, transmitterID, dstProvider)
 		if err2 != nil {
-			return err2
+			return err
 		}
 		err2 = ccipexec.UnregisterExecPluginLpFilters(srcProvider, dstProvider)
 		if err2 != nil {