Skip to content

Commit

Permalink
add tag trigger to prettier and lint (#1347)
Browse files Browse the repository at this point in the history
Somehow the change detection only works in the PR and not when the
commit is completed

commit after merge, no changes detected
See
https://github.com/smartcontractkit/ccip/actions/runs/10505474734/job/29103119475

vs 

PR CI run, changes detected, same PR

https://github.com/smartcontractkit/ccip/actions/runs/10492439900/job/29063984093?pr=1341
  • Loading branch information
RensR authored Aug 22, 2024
1 parent 9f7226a commit 2244d99
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/solidity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ jobs:
defaults:
run:
working-directory: contracts
needs: [changes]
if: needs.changes.outputs.changes == 'true'
needs: [changes, tag-check]
if: needs.changes.outputs.changes == 'true' || needs.tag-check.outputs.is-release == 'true' || needs.tag-check.outputs.is-pre-release == 'true'
name: Solidity Lint
runs-on: ubuntu-latest
steps:
Expand All @@ -169,8 +169,8 @@ jobs:
defaults:
run:
working-directory: contracts
needs: [changes]
if: needs.changes.outputs.changes == 'true'
needs: [changes, tag-check]
if: needs.changes.outputs.changes == 'true' || needs.tag-check.outputs.is-release == 'true' || needs.tag-check.outputs.is-pre-release == 'true'
name: Prettier Formatting
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit 2244d99

Please sign in to comment.