Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard bundle #55

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Add standard bundle #55

merged 6 commits into from
Jan 8, 2024

Conversation

lfortunier
Copy link

  • Use namespace after use core bundle in PasswordSafeableTrait.php
  • Use bundle smartbooster/standard-bundle, changes in :
    • /bin
    • Add configs
    • Deletes make files
    • Add Kernel
    • Add .gitignore content
    • Changes require dev
    • Changes config of phpcs, phpstan and phpunit
    • Comment base test because it doesn't work with the new smartbooster/standard-bundle implementation
  • Fix some style because of the new smartbooster/standard-bundle implementation

bin/phpunit Outdated Show resolved Hide resolved
src/Loader/ParameterLoader.php Show resolved Hide resolved
@lfortunier lfortunier force-pushed the add_standard branch 3 times, most recently from 5995cbd to 485244a Compare January 8, 2024 13:40
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lfortunier
Copy link
Author

lfortunier commented Jan 8, 2024

I comment database test because there is an initialization error on database and Kernel. It could be work, but I don't solve it now.

@mathieu-ducrot mathieu-ducrot merged commit b584830 into master Jan 8, 2024
2 checks passed
@mathieu-ducrot mathieu-ducrot deleted the add_standard branch January 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants