Merge pull request #40 from smartbooster/fix_1_3

fix infinite loop in impersonate.html.twig because of not strict comparison
smartbooster · Sep 22, 2022 · 84d4f6d · 84d4f6d
2 parents e1c7cc9 + 05a02b2
commit 84d4f6d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 CHANGELOG for 1.x
 ===================
+## v1.3.3 - (2022-09-22)
+
+### Fixed
+
+- Fixed infinite loop in impersonate.html.twig because of not strict comparison
+
 ## v1.3.2 - (2022-08-30)
 
 ### Added

diff --git a/src/Resources/SmartSonataBundle/views/action/impersonate.html.twig b/src/Resources/SmartSonataBundle/views/action/impersonate.html.twig
@@ -1,4 +1,4 @@
-{% if is_granted('ROLE_ALLOWED_TO_SWITCH') and (is_granted('ROLE_PREVIOUS_ADMIN') == false) and app.user is not null and app.user != object %}
+{% if is_granted('ROLE_ALLOWED_TO_SWITCH') and (is_granted('ROLE_PREVIOUS_ADMIN') == false) and app.user is not null and app.user.email is not same as(object.email) %}
     <a href="{{ path('sonata_admin_dashboard', {"_switch_user": object.email}) }}" class="btn btn-xs btn-default" title="{{ 'action.impersonate'|trans({}, 'admin') }}">
         <i class="fa fa-user"></i>
     </a>